On 04/25/2013 07:59 AM, Kevin Wolf wrote: > Commit 56d1b4d2 frees the QemuOpts for the driver-specific options
It looks like commit a9ccedc3d was the real culprit that introduced the problem into rbd.c, but that the problem was latent (thanks to reference counting) until 56d1b4d2 later moved its qdict_del earlier in block.c. Oops, both commits bear my review tag, which means I missed this the first time around. > immediately, even though it still needs the filename string that is > contained there. This doesn't work. Move the deletion of the QemuOpts to > the end of the function where its content isn't needed any more. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > block/rbd.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
