Am 01.05.2013 19:09, schrieb Michael Tokarev: > 30.04.2013 06:59, liguang wrote: >> Signed-off-by: liguang <lig.f...@cn.fujitsu.com> >> --- >> translate-all.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) > > Hmm. Does we require S-o-b line even for such a trivial (but nevertheless > important) stuff?
Yes: http://wiki.qemu.org/Contribute/SubmitAPatch If it's missing, author can either reply with Signed-off-by - if you're willing to fix it up - or resend. And whenever you pick up patches, you sign them off as well. > Also, Peter, does your followup email mean your Rewieved-by should be added > too? No, generally not if it was not explicitly given. Exception from the rule: We have allowed to turn an informal "ack" into an Acked-by. Thanks for taking over qemu-trivial! Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
