On 7 May 2013 18:04, Jan Kiszka <jan.kis...@siemens.com> wrote: > "Readable" is a very unfortunate name for this flag because even a > rom_device region will always be readable from the guest POV. What > differs is the mapping, just like the comments had to explain already. > Also, readable could currently be understood as being a generic region > flag, but it only applies to rom_device regions. > > So rename the flag and the function to modify it after the original term > "ROMD" which could also be interpreted as "ROM direct", i.e. ROM mode > with direct access. In any case, the scope of the flag is clearer now. > > Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> > --- > > Addresses Peter's findings except for the pflash_register_memory > argument renaming (that would require renaming the state field as well - > some other day).
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
