On Fri, May 10, 2013 at 11:04:22AM +0800, Amos Kong wrote: > On Thu, May 09, 2013 at 09:20:53PM -0500, Michael Roth wrote: > > Teach type generators about native types so they can generate the > > appropriate linked list types. > > > > Signed-off-by: Michael Roth <mdr...@linux.vnet.ibm.com> > > --- > > scripts/qapi-types.py | 43 ++++++++++++++++++++++++++++++++++++++++--- > > scripts/qapi.py | 21 +++++++++++++++++++++ > > 2 files changed, 61 insertions(+), 3 deletions(-) > > > > diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py > > index 9e19920..96cb26d 100644 > > --- a/scripts/qapi-types.py > > +++ b/scripts/qapi-types.py > > @@ -16,7 +16,18 @@ import os > > import getopt > > import errno > > <snip> > > > diff --git a/scripts/qapi.py b/scripts/qapi.py > > index afc5f32..0ac8c2b 100644 > > --- a/scripts/qapi.py > > +++ b/scripts/qapi.py > > @@ -11,6 +11,10 @@ > > > > from ordereddict import OrderedDict > > > > +builtin_types = [ > > + 'str', 'int', 'number', 'bool' > > Will we add size, int8, uint32, ... in future when they are needed?
Well, that was the plan, but I hadn't recalled that support for these was already been added to the code generators as part of the Netdev opts-visitor stuff, so I'll go ahead and do a re-spin with those added. > > > +] > > + > > -- > Amos. >