On Wed, 15 May 2013 09:32:37 -0500 mdroth <mdr...@linux.vnet.ibm.com> wrote:
> On Wed, May 15, 2013 at 09:17:46AM -0400, Luiz Capitulino wrote: > > On Fri, 10 May 2013 17:45:59 -0500 > > Michael Roth <mdr...@linux.vnet.ibm.com> wrote: > > > > > These patches apply on top of qemu.git master, and can also be obtained > > > from: > > > git://github.com/mdroth/qemu.git qapi-native-lists > > > > > > Sending this now since a number of series have popped up in the past that > > > wanted this, and Amos has some pending patches (query-mac-tables) that > > > rely > > > on this as well. > > > > > > These patches add support for specifying lists of native qapi types > > > (int/bool/str/number/int8/uint8/etc) like so: > > > > > > { 'type': 'foo', > > > 'data': { 'bar': ['int'] }} > > > > > > for a 'bar' field that is a list of type 'int', > > > > > > { 'type': 'foo2', > > > 'data': { 'bar2': ['str'] }} > > > > > > for a 'bar2' field that is a list of type 'str', and so on. > > > > > > This uses linked list types for the native C representations, just as we > > > do > > > for complex schema-defined types. In the future we may add schema > > > annotations > > > of some sort to specify a more natural/efficient array type for the C > > > representations, but this should serve the majority of uses-cases for now. > > > > I'm getting a build breakage when building all targets: > > Hmm, tested all target builds and didn't/don't see any issues. Is this a > clean build? Can you confirm whether or not int8List/etc are declared in > qapi-types.h in your current build dir? Yes, it's a clean build and yes, the int?List declarations are being generated. Tested a little bit more and this also happens with make -j1 and when building only one target (x86_64 in my case). I don't remember this happening with v1 btw, but I also don't remember if I fully built it.