[Qemu-devel] Re: [PATCH] Use msr list to load and save msrs

[Avi Kivity]

On 10/26/2009 08:26 PM, Glauber Costa wrote:

+
+    kvm_msr_list = kvm_get_msr_list(env);
+    if (!kvm_msr_list) {
+        printf("FAILED\n");
+        return -1;
+    }
+
+    msr_data.info.nmsrs = kvm_msr_list->nmsrs;
+
+    for (i = 0; i<  kvm_msr_list->nmsrs; i++) {
+        uint64_t *data = kvm_get_msr_data_addr(env, kvm_msr_list->indices[i]);
+        msrs[i].index = kvm_msr_list->indices[i];
+        if (data != NULL) {
+            msrs[i].data = *data;
+        }
+    }

      return kvm_vcpu_ioctl(env, KVM_SET_MSRS,&msr_data);

Aren't you leaking the msr list structure?

Best to get it once during setup and reuse it later.

--
error compiling committee.c: too many arguments to function