-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Il 25/05/2013 13:30, Jan Kiszka ha scritto: > On 2013-05-25 13:20, Paolo Bonzini wrote: >> Il 25/05/2013 12:19, Jan Kiszka ha scritto: >>> addr -= section->offset_within_address_space; - len = >>> MIN(section->size - addr, len); >> ^^^^^^^^^^^^^ ^^^^ >> >> This is the size of a section minus an offset in the section. >> >>> + diff = int128_sub(section->mr->size, >>> int128_make64(addr)); >> ^^^^^^^^^^^^^^^^^ ^^^^ >> >> This is the size of a region minus the same offset in the >> section. >> >>> + len = MIN(int128_get64(diff), len); >>> >>> /* Compute offset within MemoryRegion */ addr += >>> section->offset_within_region; >> >> So this has to be moved above. > > Right, fixed. > >> Do you have a branch pushed somewhere that I can test against? > > git://git.kiszka.org/qemu.git queues/ioport
And another thing... in "ioport: Switch dispatching to memory core layer", could you put memory_region_iorange_read/write in mr->ops->read/write instead of adding an "if" in the dispatch routines? Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRoc9MAAoJEBvWZb6bTYbya6IP/Rso0r/qUrRttOZYyC0GX1IL xBXZEyCDrbV49pQw9O85Lpb2BRzbUOy38RZ/gvrUfGzg9iYo+88nxoA4qiTXSKil IBxC/Nu5QCcV01zTWLE7dsjAGVVP6td2UWqtI/41T7H1OmhmN9BR2hD0hHhDT6aO f1KAhzkrdD2aOJHCyWjtehriZFH+J638QuAem8zMIC6kFGOBm475iYBI5l4haXaN k2Rx66EaOuJRFzZVscHnTw3Ohrk2QZEe8EpBScQIf3hxAlDv4wPDzXYjADUmCGhH u5dHXSDMgD3+ll5/XLAq3dX/lZPn6nJCzAqV2DPboAxhjpe5+gt0i50r91Di8T+3 Rn8ycEi5hy7Pck++ijwTDs4JGU1vGvT6xpnCmsTwiU3Tw5Yd8lNEQJyOQAMsdsrH GX+Tsqiowoq8LKVACHSOHouffUB4TM5XdUN0dPGKdohPGyDSlRlkE58mFPeBmMRT SIhaCPkykpRguNFnkxx5iLl66yUsi5Jb0qeXslffKKx6wCr6N5d3jOeb2jqjG/LT AAlQ4U5GdKbKU6rDWmcB8GeV2HZh9+ivIUwC4Q4+s+inlaXXh5V4hnNKQ8aHc2MX wBfq07Zit8bbCUvB+tYf+ORAWHUV1BFWjFRkE4sZ08ouCs45TN7Ug67334GyPvxe K5Zz+3M9ZKkvnK4kNINg =71ln -----END PGP SIGNATURE-----
