Il 03/06/2013 22:36, Jordan Justen ha scritto: > On Mon, Jun 3, 2013 at 8:19 AM, Paolo Bonzini <pbonz...@redhat.com> wrote: >> The variable is not written anymore. >> >> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> >> --- >> hw/block/pc_sysfw.c | 26 +------------------------- >> 1 file changed, 1 insertion(+), 25 deletions(-) >> >> diff --git a/hw/block/pc_sysfw.c b/hw/block/pc_sysfw.c >> index 412d1b0..c6d4be4 100644 >> --- a/hw/block/pc_sysfw.c >> +++ b/hw/block/pc_sysfw.c >> @@ -199,12 +199,6 @@ static void old_pc_system_rom_init(MemoryRegion >> *rom_memory, bool isapc_ram_fw) >> bios); >> } >> >> -/* >> - * Bug-compatible flash vs. ROM selection enabled? >> - * A few older machines enable this. >> - */ >> -bool pc_sysfw_flash_vs_rom_bug_compatible; > > Hmm. I think we still need this to retain the 1.2-1.5 compatible > behavior. But, I think I maybe my kvm readonly series didn't properly > resurrect the pc_sysfw_flash_vs_rom_bug_compatible switch.
No, we shouldn't. It only worked with TCG, and it is simpler to just document to use -pflash (instead of -bios) to run OVMF. The misfeature was dropped (with this minor backwards incompatibility) on purpose. Paolo
