On Fri, Jun 07, 2013 at 03:52:29PM -0400, Luiz Capitulino wrote:
> Signed-off-by: Luiz Capitulino <lcapitul...@redhat.com>
> ---
> block.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/block.c b/block.c
> index 79ad33d..c78f152 100644
> --- a/block.c
> +++ b/block.c
> @@ -1291,8 +1291,7 @@ int bdrv_reopen_prepare(BDRVReopenState *reopen_state,
> BlockReopenQueue *queue,
> if (local_err != NULL) {
> error_propagate(errp, local_err);
> } else {
> - error_set(errp, QERR_OPEN_FILE_FAILED,
> - reopen_state->bs->filename);
> + error_setg_file_open(errp, errno,
> reopen_state->bs->filename);
Looking closer, my suggestion was wrong too.
I think QERR_OPEN_FILE_FAILED is simply the wrong error here. We don't
know that the error occurred when trying to open a file.
errno does not necessarily contain the error value!
Stefan
