Am 10.06.2013 um 14:43 hat Peter Wu geschrieben: > On Monday 10 June 2013 14:33:28 Kevin Wolf wrote: > > Am 09.06.2013 um 12:30 hat Peter Wu geschrieben: > > > --- a/include/ui/console.h > > > +++ b/include/ui/console.h > > > @@ -339,6 +339,6 @@ int index_from_keycode(int code); > > > > > > > > > /* gtk.c */ > > > void early_gtk_display_init(void); > > > > > > -void gtk_display_init(DisplayState *ds); > > > +void gtk_display_init(DisplayState *ds, int full_screen, int no_frame); > > > > Should the new arguments be bool? > > Probably yes, but for consistency with the existing types I kept it as int. A > future patch could change all uses of "int" to "bool" where 1 or 0 are used, > do you prefer to use bool here anyway?
Yes, if you have to respin anyway, I would prefer if you changed it to bool. I mean it's not a big deal, but it moves us one step closer to consistent use of bool for boolean values, so it can't be bad. I don't think we'll ever see one big conversion patch, but as the code is touched over time, ints abused as bools will slowly disappear if we don't introduce new instances. Kevin