05.06.2013 00:23, Alon Levy wrote: > --- a/libcacard/vscclient.c > +++ b/libcacard/vscclient.c > @@ -759,5 +763,6 @@ main( > g_io_channel_unref(channel_socket); > g_byte_array_unref(socket_to_send); > > + closesocket(sock); > return 0; > }
This one isn't really needed, -- there's no need to close filedescriptors at the end of main(). I understand the memory unref/free calls above it, to make valgrind and glib trackers happy. But it ofcourse does not hurt. Besides, in all these error places it'd be really nice to print the actual cause of the problem too - like strerror(errno) or something like that. Unfortunately we had too many of these already in all parts of the code, and it really is sometimes difficult to understand WHY it fails without seeing the actual cause. I'll send a separate patch for that. Thanks, applied to the trivial patches queue. /mjt
