Il 12/06/2013 08:36, Michael Tokarev ha scritto:
> 
> Including slirp/slirp.h is somewhat dangerous since it redefines
> errno on WIN32, so any file including it may misbehave wrt errno.
> 
> Unfortunately libslirp isn't self-contained, it needs declaration
> of struct in_addr, which is provided by qemu/sockets.h.  Maybe
> instead of #including qemu/sockets.h before libslirp.h, it is
> better to make the latter self-contained.

Yeah, but I agree with having the smallest patch for now.

Reviewed-by: Paolo Bonzini <pbonz...@redhat.com>


Reply via email to