Il 13/06/2013 07:47, Kevin Wolf ha scritto: > + s->discard_passthrough[QCOW2_DISCARD_NEVER] = false, > + s->discard_passthrough[QCOW2_DISCARD_ALWAYS] = true, > + s->discard_passthrough[QCOW2_DISCARD_REQUEST] = > + qemu_opt_get_bool(opts, QCOW2_OPT_DISCARD_REQUEST, > + flags & BDRV_O_UNMAP),
I think there should not be two ways to enable it, it is confusing. > + s->discard_passthrough[QCOW2_DISCARD_SNAPSHOT] = > + qemu_opt_get_bool(opts, QCOW2_OPT_DISCARD_SNAPSHOT, true), > + s->discard_passthrough[QCOW2_DISCARD_OTHER] = > + qemu_opt_get_bool(opts, QCOW2_OPT_DISCARD_OTHER, false), Please document the defaults in qcow2_runtime_opts. (BTW, what is the rationale?) Paolo
