18.06.2013 07:45, liguang wrote: [] > -void sdl_display_init(DisplayState *ds, int full_screen, int no_frame); > +void sdl_display_init(DisplayState *ds, bool full_screen, int no_frame);
The same applies to no_frame, isn't it? These conversions to bool are like this -- "thankless", because there are so many of them all around, you touch one place and it becomes obvious that nearby places should be touched too. Like this: > --- a/vl.c > +++ b/vl.c > @@ -198,7 +198,7 @@ static int rtc_utc = 1; > static int rtc_date_offset = -1; /* -1 means no change */ > QEMUClock *rtc_clock; > int vga_interface_type = VGA_NONE; > -static int full_screen = 0; > +static bool full_screen = false; > static int no_frame = 0; > int no_quit = 0; This no_quit is bool too... :) But I think _this_ one might be in a separate patch. But it is also display-specific. Besides, I think we should rewamp this display init thing entirely, making displays to be modules and implementing options parsing properly. I think I'll do that today, and will convert these to bools while at it. Thanks, /mjt
