On Mon, Jun 24, 2013 at 12:14:07PM +0200, Igor Mammedov wrote: > On Sat, 22 Jun 2013 16:50:33 +0800 > Hu Tao <hu...@cn.fujitsu.com> wrote: > > > Cc: qemu-devel@nongnu.org > > Cc: "Andreas Färber" <afaer...@suse.de> > > Cc: Paolo Bonzini <pbonz...@redhat.com> > > Cc: Anthony Liguori <aligu...@us.ibm.com> > > Cc: Igor Mammedov <imamm...@redhat.com> > > Cc: Eduardo Habkost <ehabk...@redhat.com> > > Signed-off-by: Hu Tao <hu...@cn.fujitsu.com> > > --- > > hw/i386/kvm/clock.c | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c > > index 87d4d0f..74aa240 100644 > > --- a/hw/i386/kvm/clock.c > > +++ b/hw/i386/kvm/clock.c > > @@ -87,12 +87,11 @@ static void kvmclock_vm_state_change(void *opaque, int > > running, > > } > > } > > > > -static int kvmclock_init(SysBusDevice *dev) > > +static void kvmclock_realize(DeviceState *dev, Error **errp) > > { > > - KVMClockState *s = FROM_SYSBUS(KVMClockState, dev); > > + KVMClockState *s = DO_UPCAST(KVMClockState, busdev.qdev, dev); > it would be better to swap this patch with 22/26 and use KVM_CLOCK() cast here
OK. I'll swap them in next version.