On 11/07/09 16:22, Blue Swirl wrote:
In general the commits look good, there are many obviously correct cleanups.
However, what happens to the DPRINTFs, it looks like they are removed
in the process?
I guess you are talking about the ones for each emulated command in
scsi-disk.c? There is scsi_print_req() now, filling this hole. I'll
stick in a call, wrapped into #ifdef DEBUG_SCSI, so you'll get this
printed by default when compiling with debugging enabled.
You are also moving the compilation to Makefile.hw, which is not
exactly an improvement. Is this needed because of the QEMUIOVector
stuff?
Almost correct ;)
It is because of QEMUSGList which drags in a target_phys_addr_t dependency.
cheers,
Gerd
