On 06/27/2013 07:52 AM, Peter Lieven wrote: > .has_zero_init defaults to 1 for all formats and protocols. > > this is a dangerous default since this means that all > new added drivers need to manually overwrite it to 0 if > they do not ensure that a device is zero initialized > after bdrv_create(). > > if a driver needs to explicitly set this value to > 1 its easier to verify the correctness in the review process. > > during review of the existing drivers it turned out > that ssh and gluster had a wrong default of 1. > both protocols support host_devices as backend > which are not by default zero initialized. this > wrong assumption will lead to possible corruption > if qemu-img convert is used to write to such a backend. > > a similar problem with the wrong default existed for > iscsi mose likely because the driver developer did
s/mose/most/ -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
