Am 28.06.2013 14:44, schrieb Peter Maydell: > On 28 June 2013 13:20, Mian M. Hamayun <m.hama...@virtualopensystems.com> > wrote: >> This patch series implements KVM support in QEMU for the ARMv8 Cortex >> A57 CPU. >> It depends on the previously submitted AArch64 Preparation Patchset V4, >> and uses >> as a base, the existing Versatile Express machine model and the already >> available KVM in-kernel GIC support. > > This rather overlaps with a bunch of work John Rigby has already done > (though not yet published to the mailing lists): > > https://git.linaro.org/gitweb?p=people/pmaydell/qemu-aarch64.git;a=shortlog;h=refs/heads/kvm-aarch64-wip > > so now we need to reconcile the two trees. If you'd let us know > you were doing this a bit earlier we could probably have > coordinated something...
I had been looking into that tree myself, and apart from John's Linux'ish "ARM: " prefixes rather than our usual "target-arm: " (part of which you forgot to fix before sending a PULL), I am really opposed to copying A15MPCore_priv for A57. I plan to post a cleanup for the A9 version the weekend, now that we have a more elaborate hw/ directory structure for headers. Also I would really prefer to have the is_aarch64() helper operate on ARMCPU rather than CPUARMState. QOM cast removal is underway to make that more efficient. Is there a 32-bit aarch64 register in ARMv8 to be accessed by TCG? If not, the field should be in ARMCPU and a bool rather than uint32_t. Regards, Andreas P.S. This cover letter got submitted separate from the actual patches so that they are not marked RFC - please use --subject-prefix="RFC" or the like and suggest to indicate there against which tree it is. -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg