On 28 June 2013 14:26, Paolo Bonzini <pbonz...@redhat.com> wrote: > > +/* This is thread-local depending on __linux__ because:
Is the comment perhaps unchanged from an earlier revision that used a different test? It seems odd to me to reference __linux__ here. > + * - the only -user mode supporting multiple VCPU threads is linux-user > + * - TCG system mode is single-threaded regarding VCPUs > + * - KVM system mode is multi-threaded but limited to Linux > + */ > +#if defined CONFIG_KVM || (defined CONFIG_USER_ONLY && defined > CONFIG_USE_NPTL) Also, in discussion on the FreeBSD bsd-user patch set the suggestion was made that we do away with a flag, and just have thread support always enabled. Would you suggest this test then become KVM || (USER_ONLY && (USE_NPTL || __FreeBSD__))?
