On 06.07.2013, at 12:45, Peter Maydell wrote: > On 6 July 2013 01:36, Alexander Graf <ag...@suse.de> wrote: >> diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h >> index 8b06a19..fbc3cac 100644 >> --- a/linux-user/syscall_defs.h >> +++ b/linux-user/syscall_defs.h >> @@ -2434,8 +2434,11 @@ typedef union target_epoll_data { >> >> struct target_epoll_event { >> uint32_t events; >> +#ifdef TARGET_ARM >> + uint32_t __pad; >> +#endif >> target_epoll_data_t data; >> -}; >> +} QEMU_PACKED; >> #endif >> struct target_rlimit64 { >> uint64_t rlim_cur; > > Is ARM really the only arch that needs the pad field?
It's the only one I definitely know about. Other targets may add it as they see fit. It shouldn't be more broken than before really, where we just took random host alignment. Alex