On Fri, 12 Jul 2013 08:58:03 +0200 Paolo Bonzini <pbonz...@redhat.com> wrote:
> Il 10/07/2013 19:52, Luiz Capitulino ha scritto: > > From: Seiji Aguchi <seiji.agu...@hds.com> > > > > [Issue] > > When we offer a customer support service and a problem happens > > in a customer's system, we try to understand the problem by > > comparing what the customer reports with message logs of the > > customer's system. > > > > In this case, we often need to know when the problem happens. > > > > But, currently, there is no timestamp in qemu's error messages. > > Therefore, we may not be able to understand the problem based on > > error messages. > > > > [Solution] > > Add a timestamp to qemu's error message logged by > > error_report() with g_time_val_to_iso8601(). > > > > Signed-off-by: Seiji Aguchi <seiji.agu...@hds.com> > > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> > > Signed-off-by: Luiz Capitulino <lcapitul...@redhat.com> > > What about removing the option, and instead: > > - logging no timestamp until the virtual machine has started You mean, the guest has started? Why? What about if an error happens before the guest has started? > - always logging timestamps after the virtual machine has started I don't like having this enabled by default, because it makes error messages pretty verbose and also because it's not human readable at a first glance. So, IMO, only people who really want this should enable it.