On 13 July 2013 05:12, Michael Tokarev <m...@tls.msk.ru> wrote: > Remaining: > > struct mbuf { > union M_dat { > char m_dat_[1]; /* ANSI don't like 0 sized arrays */ > char *m_ext_; > } M_dat; > }; > > #define m_dat M_dat.m_dat_ > #define m_ext M_dat.m_ext_ > > This can be done by using an unnamed union, ie, by omitting >
Yeah, struct mbuf and those #defines date back to the beginning of BSD networking. I think we're probably unconcerned with a slirp upstream at this point, so such a change seems reasonable. I'm not sure that anonymous union support is universal across all compilers used to build QEMU though - do you know?