ping ________________________________________ From: Petar Jovanovic Sent: Monday, July 08, 2013 11:20 AM To: Richard Henderson Cc: Petar Jovanovic; qemu-devel@nongnu.org; aurel...@aurel32.net Subject: RE: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
ping http://patchwork.ozlabs.org/patch/245990/ ________________________________________ From: Richard Henderson [rth7...@gmail.com] on behalf of Richard Henderson [r...@twiddle.net] Sent: Thursday, June 27, 2013 8:26 PM To: Petar Jovanovic Cc: Petar Jovanovic; qemu-devel@nongnu.org; aurel...@aurel32.net Subject: Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15 On 06/17/2013 03:40 PM, Petar Jovanovic wrote: > From: Petar Jovanovic <petar.jovano...@imgtec.com> > > Multiplication of Q15 fractional halfword vectors was incorrect in the > previous implementation of mipsdsp_rndq15_mul_q15_q15. It failed to take > element signs into account. This change fixes it, and it adds a test case > for it. > > The change also removes unnecessary cast in the function > mipsdsp_mul_q15_q15_overflowflag21(). > > Signed-off-by: Petar Jovanovic <petar.jovano...@imgtec.com> > --- > target-mips/dsp_helper.c | 4 ++-- > tests/tcg/mips/mips32-dsp/mulq_rs_ph.c | 19 ++++++++++++++++++- > 2 files changed, 20 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson <r...@twiddle.net> r~
