On Thu, Jul 18, 2013 at 12:56:51PM -0600, Eric Blake wrote: > On 07/18/2013 12:47 PM, Ian Main wrote: > > qcow2 supports backing files so it makes sense to default to qcow2 > > for MIRROR_SYNC_MODE_NONE so that we can use the source as a backing > > drive and export it via nbd. Defaulting FULL and TOP to SYNC_MODE_NONE > > breaks tests but that could be fixed if we wanted it. > > > > Signed-off-by: Ian Main <im...@redhat.com> > > --- > > blockdev.c | 5 ++++- > > qapi-schema.json | 1 + > > 2 files changed, 5 insertions(+), 1 deletion(-) > > Looks okay, but let's answer the meta-question first of whether we > should just make 'format' mandatory and be done with it. > > Also, I've noticed you aren't cc'ing many people; that can slow down > reviews. http://wiki.qemu.org/Contribute/SubmitAPatch gives hints on > how to determine the right people to send your patches to, by > deciphering MAINTAINERS and running ./scripts/getmaintainer.pl.
Ah ok, I'll add them next rev. My take has been to just do a patch that implements the suggestion and see what people think :). Ian