Am 29.06.2013 17:10, schrieb Stefan Weil: > The current code includes assert.h very early (from qemu-common.h), > so the definition of NDEBUG was without any effect. > > In the initial version from 2004, NDEBUG was used to disable the assertions. > Those assertions are not in time critical code, so it is no longer > reasonable to disable them and the definition of NDEBUG can be removed. > > Type u16 is also unused and therefore does not need a type definition. > > Signed-off-by: Stefan Weil <s...@weilnetz.de> > --- > util/aes.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/util/aes.c b/util/aes.c > index 91e97fa..4b4d88e 100644 > --- a/util/aes.c > +++ b/util/aes.c > @@ -30,12 +30,7 @@ > #include "qemu-common.h" > #include "qemu/aes.h" > > -#ifndef NDEBUG > -#define NDEBUG > -#endif > - > typedef uint32_t u32; > -typedef uint16_t u16; > typedef uint8_t u8; > > /* This controls loop-unrolling in aes_core.c */
Please apply this patch to the qemu-trivial queue, and maybe this one, too: http://patchwork.ozlabs.org/patch/257416/. Thanks, Stefan