malc wrote:
On Sat, 14 Nov 2009, Sebastian Herbszt wrote:
v0.11.0-rc0-1630-g51cc2e7 fails to build on mingw with gcc version 3.4.5
(mingw32 special)
and GNU Make version 3.79.1.
gcc -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7/slirp -Wold-style-definition
-I.
-I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7 -U_FORTIFY_SOURCE -D_GNU_SOURCE
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wendif-labels
-Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing
-m32 -DWIN32_LEAN_AND_MEAN -DWINVER=0x501
-MMD -MP -MT audio/mixeng.o -O2 -g -c -o audio/mixeng.o audio/mixeng.c
gcc -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7/slirp -Wold-style-definition
-I.
-I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7 -U_FORTIFY_SOURCE -D_GNU_SOURCE
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wendif-labels
-Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing
-m32 -DWIN32_LEAN_AND_MEAN -DWINVER=0x501
-MMD -MP -MT -I/mingw/include/SDL -D_GNU_SOURCE=1 -Dmain=SDL_main -O2 -g -c -o
audio/sdlaudio.o audio/sdlaudio.c
audio/sdlaudio.c:24:17: warning: SDL.h: No such file or directory
audio/sdlaudio.c:25:24: warning: SDL_thread.h: No such file or directory
Notice the missing parameter for "-MT" with sdlaudio, but not mixeng. Before
commit
02d5467e9f43dac05f04999e387108ca4c8ba140 "-MT" was followed by
"-U_FORTIFY_SOURCE", but now it's "-I/mingw/include/SDL"
which gets swallowed.
Neither is/was correct, does escaping $@ in rules make (i.e. \$@) have
any effect?
Changing it to \$@ makes it compile again:
$ grep MMD rules.mak
QEMU_CFLAGS += -MMD -MP -MT \$@
gcc -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7-nox-fixed/slirp
-Wold-style-definition
-I. -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7-nox-fixed -U_FORTIFY_SOURCE
-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wendif-labels
-Wwrite-strings
-Wmissing-prototypes -fno-strict-aliasing -m32 -DWIN32_LEAN_AND_MEAN
-DWINVER=0x501 -MMD -MP -MT audio/mixeng.o -O2 -g -c -o audio/mixeng.o
audio/mixeng.c
gcc -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7-nox-fixed/slirp
-Wold-style-definition
-I. -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7-nox-fixed -U_FORTIFY_SOURCE
-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wendif-labels
-Wwrite-strings
-Wmissing-prototypes -fno-strict-aliasing -m32 -DWIN32_LEAN_AND_MEAN
-DWINVER=0x501 -MMD -MP -MT -I/mingw/include/SDL -D_GNU_SOURCE=1
-Dmain=SDL_main -O2 -g -c -o audio/sdlaudio.o audio/sdlaudio.c
gcc -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7-nox-fixed/slirp
-Wold-style-definition
-I. -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7-nox-fixed -U_FORTIFY_SOURCE
-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wendif-labels
-Wwrite-strings
-Wmissing-prototypes -fno-strict-aliasing -m32 -DWIN32_LEAN_AND_MEAN
-DWINVER=0x501 -MMD -MP -MT audio/winwaveaudio.o -O2 -g -c
-o audio/winwaveaudio.o audio/winwaveaudio.c
The only difference i notice are more spaces:
-MMD -MP -MT -I/mingw/include/SDL
vs.
-MMD -MP -MT -I/mingw/include/SDL
- Sebastian
