Am 23.07.2013 11:59, schrieb Michael S. Tsirkin: > On Tue, Jul 23, 2013 at 11:10:45AM +0200, Andreas Färber wrote: >> Am 23.07.2013 09:07, schrieb Michael S. Tsirkin: >>> On Mon, Jul 22, 2013 at 11:04:49PM +0200, Andreas Färber wrote: >>>> For VMState I believe the real follow-up fix would be mst defining a >>>> central macro VMSTATE_PCI_DEVICE_AER_LOG() operating on PCIDevice. >>>> Why is that separate from VMSTATE_PCI_DEVICE() or VMSTATE_PCIE_DEVICE() >>>> in the first place? > > I think the answer is that most pcie devices > don't implement AER. AFAIK PCI devices can't > support AER at all.
Okay, so if it's just PCIe, then XHCI is the oddball preventing moving it into VMSTATE_PCIE_DEVICE(). XHCI has VMSTATE_MSIX() in its place, also operating on PCIDevice. Is there a way to detect use of AER or MSIX to place those into subsections of VMSTATE_PCIE_DEVICE()? Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
