--On 26 July 2013 13:16:04 -0600 Eric Blake <ebl...@redhat.com> wrote:
- while (qemu_co_queue_next(&bs->throttled_reqs));
+ while (qemu_co_enter_next(&bs->throttled_reqs)) {
+ }
On first read, I missed the s/queue/enter/ change and thought all you
were doing was the s/;/{}/ change. Is the style change necessary to
keep checkpatch.pl happy? If not, then keeping the old style would draw
better attention to the bug fix.
checkpatch.pl doesn't like:
while (func());
It appears happy with:
do {} while (func());
which is marginally less ugly than:
while (func()) {
};
in my opinion, particularly when used multiple times in succession.
I think this is probably a bug in checkpatch.pl.
--
Alex Bligh
