31.07.2013 16:03, Andreas Färber wrote: > Am 31.07.2013 13:05, schrieb Peter Maydell: >>> Actually the more I think about it... Maybe it shouldn't depend >>> on --enable-tools either, but should be an independent option. >>> Because it isn't really a tool. >> >> This seems to me to be unnecessarily breaking things down >> into very finely divided categories. I think putting it >> in --enable-tools is fine. > > I disagree. Think about building a Windows guest agent: You don't need > qemu-img (tools) on a Windows guest, and mjt is right that it shouldn't > be coupled to building any qemu-system-*.
It's not a tool, but indeed that's unnecessary too fine-grained. I'm not sure which way is preferrable :) > However it looks as if the linux/bsd/solaris checks got lost in the patch? No, the new place is already within linux/bsd/solaris conditional. /mjt