On 2013-08-05 14:06, Andreas Färber wrote: > Am 02.08.2013 19:22, schrieb Andreas Färber: >> Error **errp argument is not for emitting warnings, it means an error >> has occurred and the caller should not make any assumptions about the >> state of other return values (unless otherwise documented). >> >> Therefore cpu_x86_create() must unref the new X86CPU itself, and >> pc_new_cpu() must check for an Error rather than NULL return value. >> >> While at it, clean up a superfluous NULL check. >> >> Reported-by: Jan Kiszka <jan.kis...@siemens.com> >> Cc: qemu-sta...@nongnu.org >> Cc: Igor Mammedov <imamm...@redhat.com> >> Signed-off-by: Andreas Färber <afaer...@suse.de> > > Ping! Jan, does this address your concerns / use cases? > -rc2 is on Wednesday.
Yes, thanks, this looks good. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux
