On Mon, Aug 05, 2013 at 08:33:10PM +0100, Charlie Shepherd wrote: > Yes that does merit some explanation.
Thanks for the details. > qemu_co_queue_run_restart is a bit different. It is only called from > coroutine_swap in qemu-coroutine.c, and it enters coroutines that > were waiting but have now moved to the runnable state by the actions > of the most recent coroutine (I believe). I think we discussed this > on IRC on Thursday? It only calls qemu_coroutine_enter, and cannot > yield, so again I removed the annotation. I'll add these > explanations to the commit message. Or maybe split those in different commits altogether? I find it often easier to review many small commits than a big one, each focused on an "atomic" change. -- Gabriel