Stefan Weil wrote: > A code review run by Steve Grubb complained about code in e1000.c: > > In hw/e1000.c at line 89, vlan is declared to be 4 bytes. > At line 382 is an attempt to do a memmove over it with a size of 12.
> + /* Fields vlan and data must not be reordered or separated. */ > unsigned char vlan[4]; > unsigned char data[0x10000]; Wouldnt it be better to stuff both into a struct or something? I guess from the '12' that the data size can vary, but thats less important if they are packed in a way that the compiler (and coders!) know not to seperate them. -Ian
