Quoting Tomoki Sekiyama (2013-08-07 10:39:25) > Hi, > > I rebased the patch series to add fsfreeze for Windows qemu-ga. > > changes from v9: > - Fix conflict with commit e8ef31a3518c "qemu-ga: build it even if !system" > > changes from v8: > - Add hEventTimeout to improve timeout error message (patch 07, see below) > - Build qga-vss.tlb if configure'd --with-win-sdk (patch 05, 07) > - Use "qga-vss-dll-obj-$(CONFIG_QGA_VSS)" in Makefile.objs (patch 07) > - Fix typo in QGAVSSRequesterFunc (patch 07, 08)
Everything looks good, went ahead and applied to qga branch and will send a PULL shortly after 1.7 development window opens up: https://github.com/mdroth/qemu/commits/qga Thanks for the series! > > v9: http://lists.nongnu.org/archive/html/qemu-devel/2013-07/msg06071.html > > * Description > In Windows, VSS (Volume Shadow Copy Service) provides a facility to > quiesce filesystems and applications before disk snapshots are taken. > This patch series implements "fsfreeze" command of qemu-ga using VSS. > > > * How to build & run qemu-ga with VSS support > > - Download Microsoft VSS SDK from: > http://www.microsoft.com/en-us/download/details.aspx?id=23490 > > - Setup the SDK > scripts/extract-vsssdk-headers setup.exe (on POSIX-systems) > > - Specify installed SDK directory to configure option as: > ./configure --cross-prefix=i686-w64-mingw32- \ > --with-vss-sdk="path/to/VSS SDK" \ > --without-systems --without-tools > > - make qemu-ga.exe qga/vss-win32/qga-vss.{dll,tlb} > > - Install qemu-ga.exe, qga/vss-win32/qga-vss.{dll,tlb}, and > the other required mingw libraries into the same directory in guests > > - Run `qemu-ga.exe -s install' and `net start qemu-ga' in the guests > > Any feedback are appreciated. > > --- > Tomoki Sekiyama (10): > configure: Support configuring C++ compiler > Add c++ keywords to QAPI helper script > checkpatch.pl: Check .cpp files > Add a script to extract VSS SDK headers on POSIX system > qemu-ga: Add configure options to specify path to Windows/VSS SDK > error: Add error_set_win32 and error_setg_win32 > qemu-ga: Add Windows VSS provider and requester as DLL > qemu-ga: Call Windows VSS requester in fsfreeze command handler > qemu-ga: Install Windows VSS provider on `qemu-ga -s install' > QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze > command > > > .gitignore | 1 > Makefile | 3 > Makefile.objs | 2 > QMP/qemu-ga-client | 4 > configure | 96 +++++++ > hmp.c | 2 > hw/pci/pci.c | 2 > include/qapi/error.h | 13 + > qga/Makefile.objs | 3 > qga/commands-win32.c | 82 ++++++ > qga/main.c | 10 + > qga/vss-win32.c | 166 +++++++++++++ > qga/vss-win32.h | 27 ++ > qga/vss-win32/Makefile.objs | 23 ++ > qga/vss-win32/install.cpp | 458 +++++++++++++++++++++++++++++++++++ > qga/vss-win32/provider.cpp | 523 > ++++++++++++++++++++++++++++++++++++++++ > qga/vss-win32/qga-vss.def | 13 + > qga/vss-win32/qga-vss.idl | 20 ++ > qga/vss-win32/qga-vss.tlb | Bin > qga/vss-win32/requester.cpp | 507 +++++++++++++++++++++++++++++++++++++++ > qga/vss-win32/requester.h | 42 +++ > qga/vss-win32/vss-common.h | 129 ++++++++++ > rules.mak | 9 + > scripts/checkpatch.pl | 34 ++- > scripts/extract-vsssdk-headers | 35 +++ > scripts/qapi.py | 12 + > util/error.c | 35 +++ > 27 files changed, 2229 insertions(+), 22 deletions(-) > create mode 100644 qga/vss-win32.c > create mode 100644 qga/vss-win32.h > create mode 100644 qga/vss-win32/Makefile.objs > create mode 100644 qga/vss-win32/install.cpp > create mode 100644 qga/vss-win32/provider.cpp > create mode 100644 qga/vss-win32/qga-vss.def > create mode 100644 qga/vss-win32/qga-vss.idl > create mode 100644 qga/vss-win32/qga-vss.tlb > create mode 100644 qga/vss-win32/requester.cpp > create mode 100644 qga/vss-win32/requester.h > create mode 100644 qga/vss-win32/vss-common.h > create mode 100755 scripts/extract-vsssdk-headers