On 9 Aug 2013, at 10:23, Stefan Hajnoczi wrote: > On Thu, Aug 08, 2013 at 10:42:20PM +0100, Alex Bligh wrote: >> @@ -269,17 +299,17 @@ bool timerlist_expired(QEMUTimerList *timer_list); >> int64_t timerlist_deadline_ns(QEMUTimerList *timer_list); >> >> /** >> - * timerlist_getclock: >> + * timerlist_get_clock: >> * @timer_list: the timer list to operate on >> * >> * Read the clock value associated with a timer list. >> * The clock value is normally in nanoseconds, but may >> * not be in some instances (e.g. vm_clock with use_icount). > > The documentation is wrong. This function does not get the clock value > in nanoseconds.
I will fix. >> +/** >> + * timer_put: >> + * @f: the file >> + * @ts: the timer >> + */ >> +void timer_put(QEMUFile *f, QEMUTimer *ts); > > The struct is still called QEMUTimer, should that also be renamed? I could do but it might produce another patch too large for the mailing list. Suggest we leave it as it is for now. -- Alex Bligh