On 12 Aug 2013, at 07:22, Fam Zheng wrote: >> --- a/qemu-img.c >> +++ b/qemu-img.c >> @@ -103,6 +103,7 @@ static void help(void) >> " '-S' indicates the consecutive number of bytes that must >> contain only zeros\n" >> " for qemu-img to create a sparse image during conversion\n" >> " '--output' takes the format in which the output must be done >> (human or json)\n" >> + " '-C' skips the target volume creation (useful for rbd)\n" > > The statement "useful for rbd" is not very informative, maybe you could > use "'-C' skips the target volume creation (assuming it already exists)".
Done with slightly different text - see v2 just posted >> static int img_convert(int argc, char **argv) >> { >> - int c, ret = 0, n, n1, bs_n, bs_i, compress, cluster_size, >> cluster_sectors; >> + int c, ret = 0, n, n1, bs_n, bs_i, compress, cluster_size, >> cluster_sectors, skipcreate; > > This line is too long, please break it. Done in v2 just posted. -- Alex Bligh