On 19 August 2013 09:26, Fabien Chouteau <chout...@adacore.com> wrote:
> Any comments?
>
> Regards,
>
> On 08/02/2013 02:48 PM, Fabien Chouteau wrote:
>> Signed-off-by: Fabien Chouteau <chout...@adacore.com>
>> ---
>> monitor.c | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/monitor.c b/monitor.c
>> index 5dc0aa9..78e93af 100644
>> --- a/monitor.c
>> +++ b/monitor.c
>> @@ -3167,6 +3167,23 @@ static const MonitorDef monitor_defs[] = {
>> { "cleanwin", offsetof(CPUSPARCState, cleanwin) },
>> { "fprs", offsetof(CPUSPARCState, fprs) },
>> #endif
>> +#elif defined(TARGET_ARM)
>> + { "r0", offsetof(CPUARMState, regs[0]) },
>> + { "r1", offsetof(CPUARMState, regs[1]) },
Rather than adding yet another entry to this target-ifdef
ladder in common code, maybe we can abstract this out to be
a method/field of the CPU object?
Andreas can probably suggest the best approach.
thanks
-- PMM
