On 2013/8/28 20:53, Eric Blake wrote:
On 08/12/2013 10:31 PM, Dong Xu Wang wrote:
qemu_opts_print has no user now, so can re-write the function safely.
qemu_opts_print is used while using "qemu-img create", it
produces the same output as previous code.
The behavior of this function has changed:
1. Print every possible option, whether a value has been set or not.
2. Option descriptors may provide a default value.
3. Print to stdout instead of stderr.
Previously the behavior was to print every option that has been set.
Options that have not been set would be skipped.
v17->v18:
1) print opt->value.uint directly while type is QEMU_OPT_SIZE.
When making a change to a previously-reviewed patch, unrelated to the
reviewer's comments...
Reviewed-by: Eric Blake <ebl...@redhat.com>
Signed-off-by: Dong Xu Wang <wdon...@linux.vnet.ibm.com>
...it is probably better to drop the earlier Reviewed-by: to make sure
that the change gets properly reviewed. Keeping a Reviewed-by makes
sense only when carrying a patch with no changes, or when the set of
changes made are trivial in nature (such as whitespace cleanups) or
explicitly mentioned as the changes desired by the reviewer.
Okay, thank you, Eric.
