On 11 September 2013 06:38, Fam Zheng <f...@redhat.com> wrote:
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -34,6 +34,7 @@
>  #include "qemu/timer.h"
>  #include "qemu/envlist.h"
>  #include "elf.h"
> +#include <qemu/module.h>
>
>  char *exec_path;
>
> @@ -3551,6 +3552,8 @@ int main(int argc, char **argv, char **envp)
>      int i;
>      int ret;
>
> +    module_load(MODULE_LOAD_UI);
> +    module_load(MODULE_LOAD_NET);
>      module_call_init(MODULE_INIT_QOM);

This looks kind of fishy. The *-user binaries don't even
have any UI, and they shouldn't be using the networking
either. For that matter it's really unclear to me that they
should have any kind of loadable modules at all.

-- PMM

Reply via email to