Re: [Qemu-devel] [PATCH v3 03/29] tcg-aarch64: Don't handle mov/movi in tcg_out_op

[Claudio Fontana]

On 12.09.2013 16:02, Richard Henderson wrote:
> On 09/12/2013 01:30 AM, Claudio Fontana wrote:
>>> +    case INDEX_op_mov_i64:
>>> +    case INDEX_op_mov_i32:
>>> +    case INDEX_op_movi_i64:
>>> +    case INDEX_op_movi_i32:
>>> +        /* Always implemented with tcg_out_mov/i, never with tcg_out_op.  
>>> */
>>>      default:
>>> -        tcg_abort(); /* opcode not implemented */
>>> +        /* Opcode not implemented.  */
>>> +        tcg_abort();
>>>      }
>>>  }
>>>  
>>
>> Ok
> 
> Sadly, "Ok" is neither Reviewed-by or Signed-off-by.
> 
> 

There is nothing sad about it. When it's reviewed, you will know.