14.09.2013 19:30, Stefan Weil wrote:
Am 14.09.2013 14:18, schrieb Michael Tokarev:
[]
Well. I see at least one hidden flag here which is not covered by the
description:
-gcc_flags="-Wendif-labels $gcc_flags"
+gcc_flags="-fstack-protector-all -Wendif-labels $gcc_flags"
Is it intentional?
No, -fstack-protector-all should not be there. It might be a relict of
a previous patch rebase: I added -Wextra in my local branch a long
time ago, and -fstack-protector-all was obviously moved to another
location in configure during that time.
I can send an updated patch later, or you can just remove it from
my original patch.
Please take a look at the resulting patch at
http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/trivial-patches-next
and see if this is the patch you want to be applied.
I verified it compiles on FreeBSD 9.1, but I tried only minimal set
of optional dependencies so things might still break, but I think
we can fix it later.
If it looks okay, I'll send a pull request today.
Thanks,
/mjt
