Am 15.09.2013 02:03, schrieb Richard Henderson: > During GEN_HELPER=1, these are actually stray top-level semi-colons > which are technically invalid ISO C, but GCC accepts as an extension. > If we added enough __extension__ markers that we could dare use > -Wpedantic, we'd see > > warning: ISO C does not allow extra ‘;’ outside of a function > > This will become a hard error in the next patch, wherein those ; will > appear in the middle of a data structure. > > Signed-off-by: Richard Henderson <r...@twiddle.net> > ---
Instead of removing the semicolons from the DEF_HELPER_x lines, I'd prefer removing them from the DEF_HELPER_FLAGS_x definitions. Code formatters and static code analyzers (maybe humans, too) prefer lines which look like valid C syntax, therefore DEF_HELPER_FLAGS_1(ctpop, TCG_CALL_NO_RWG_SE, i64, i64); is better for such tools than DEF_HELPER_FLAGS_1(ctpop, TCG_CALL_NO_RWG_SE, i64, i64) The compiler will also complain if someone adds a new DEF_HELPER_FLAGS_x without semicolon in the first case, but it won't complain if someone adds it with semicolon in the second case. Regards, Stefan
