On 09/18/2013 01:23 AM, Mark Wu wrote: > Now we have several qemu-ga commands not returning response on success. > It has been documented in qga/qapi-schema.json already. This patch exposes > the 'success-response' flag by extending 'guest-info' command. With this > change, the clients can handle the command response more flexibly. > > Signed-off-by: Mark Wu <wu...@linux.vnet.ibm.com> > --- > include/qapi/qmp/dispatch.h | 1 + > qapi/qmp-registry.c | 13 +++++++++++++ > qga/commands.c | 2 ++ > qga/qapi-schema.json | 4 +++- > 4 files changed, 19 insertions(+), 1 deletion(-) >
> +++ b/qga/qapi-schema.json > @@ -141,10 +141,12 @@ > # > # @enabled: whether command is currently enabled by guest admin > # > +# @success-response: whether command returns a response on success Please add the notation (since 1.7) to this option, to document that it was not present in 1.1.0. Other than that, looks okay to me. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
