Am 19.09.2013 20:53, schrieb Eric Blake: > On 09/17/2013 07:48 AM, Peter Lieven wrote: >> Signed-off-by: Peter Lieven <p...@kamp.de> >> --- >> include/block/block_int.h | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) > Reviewed-by: Eric Blake <ebl...@redhat.com> > >> + >> + /* optimal alignment for write zeroes requests in sectors */ >> + int64_t write_zeroes_alignment; >> + Paolo voted for a BlockLimits struct to be nested into the BlockDriverState. It would make it easier if the settings have to be copied (like in raw_open). There might be more limits in the future so it might be good that its not necessary to change the code everywhere.
>> /* do we need to tell the quest if we have a volatile write cache? */ >> int enable_write_cache; > Hmm, I just pointed out to Paolo that this ought to be bool. But as it > is in the context and not your actual patch, it has no bearing on this > series, and even if that gets changed first, git's pretty good about > context-only conflict resolution. > If I put a v3 which is likely I can put a patch for that in as well. Peter
