Am 19.09.2013 um 20:43 hat Jeff Cody geschrieben:
> Several block image formats did not consistently use packed attributes
> when directly reading / writing structures from disk (mainly image format
> headers).
> 
> These series updates the image formats (see list below), to use
> QEMU_PACKED for on-disk structs.  (Some minor code cleanup may also
> have ensued, to keep checkpatch.pl happy)

One comment on coding style: It seems to be more common to have the
QEMU_PACKED attribute after the fields, i.e.:

    struct foo {
        ...
    } QEMU_PACKED;

Kevin

Reply via email to