On Wed, Sep 25, 2013 at 05:02:45PM -0400, Jeff Cody wrote: > > This patch series contains the initial VHDX log parsing, replay, > write support, and image creation. > > === v6 changes === > https://github.com/codyprime/qemu-kvm-jtc/tree/vhdx-write-v6-upstream > > Rebased to latest qemu/master: > > Patch 16/20: .bdrv_create() propagates Error, and bdrv_unref() used > instead of bdrv_delete(). > > Patch 17 & 18 are already included in another series: > [PATCH v3 0/3] qemu-iotests with sample images, vhdx test, cleanup > > They are included here to provide a base for patches 19 & 20. If the above > series is applied before this series, then patches 17 and 18 can be ignored. > > Patch 19/20: In qemu-io tests _make_test_img(), filter out vhdx-specific > options for .bdrv_create(). > > Patch 20/20: Add VHDX write test case to 064.
Sorry for the late review. Feel free to poke Kevin or me if we're being slow - the squeaky wheel gets the grease. I left comments on a couple of the core journal and write patches. It looks pretty good overall. How is the journal code tested? IIUC the sample image file does not have a dirty journal. Please try to include an image that Hyper-V created with a dirty journal so we can be sure flushing the journal works. Stefan
