Am 01.10.2013 10:11, schrieb Sebastian Ottlik: > On 23.09.2013 12:33, Sebastian Ottlik wrote: >> On 18.09.2013 18:58, Stefan Weil wrote: >>> If failures only happen when something is very wrong (like an invalid >>> socket id), >>> an assertion might be better, and we could remove the 'silent' >>> parameter. >>> >>> Stefan >>> >> IMO for debug builds this is a good idea. However, in production use >> it is probably preferable to keep QEMU running, as a failure won't be >> too critical. From a quick grep it looks like NDEBUG is not set so >> assertions wont be removed for non-debug builds. I don't feel >> acquainted enough with the source code to decide about this kind of >> change in functionality, which is why I was waiting so long to reply. > ping
Running QEMU with an invalid socket id is not preferable. It's better to get a dozen of assertions in production and fix the code than to have hundreds of production systems running with hidden bugs. Those users who don't agree can build QEMU with -DNDEBUG and use the close-your-eyes strategy "if error then no error". Therefore I strongly suggest adding an assertion and removing the 'silent' parameter. Regards, Stefan
