On 5 October 2013 01:57, Fabien Chouteau <chout...@adacore.com> wrote:
> --- a/target-i386/cpu-qom.h > +++ b/target-i386/cpu-qom.h > @@ -23,6 +23,7 @@ > #include "qom/cpu.h" > #include "cpu.h" > #include "qapi/error.h" > +#include "monitor/monitor_def.h" > #ifdef TARGET_X86_64 > #define TYPE_X86_CPU "x86_64-cpu" > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index b682802..616b7da 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -22,6 +22,7 @@ > #include <inttypes.h> > > #include "cpu.h" > +#include "cpu-qom.h" > #include "sysemu/kvm.h" > #include "sysemu/cpus.h" > #include "topology.h" > @@ -47,7 +48,9 @@ > #include "hw/xen/xen.h" > #include "hw/i386/apic_internal.h" > #endif > +#include "monitor/monitor_def.h" > > +extern const MonitorDef i386_monitor_defs[]; Declare this in cpu-qom.h, rather than having an extern declaration in a .c file. > --- a/target-sparc/cpu-qom.h > +++ b/target-sparc/cpu-qom.h > @@ -21,7 +21,6 @@ > #define QEMU_SPARC_CPU_QOM_H > > #include "qom/cpu.h" > -#include "cpu.h" ...why have you deleted this #include ? > > #ifdef TARGET_SPARC64 > #define TYPE_SPARC_CPU "sparc64-cpu" thanks -- PMM