Il 14/10/2013 18:45, Eduardo Habkost ha scritto:
> +        if (field->field_exists && !field->field_exists(opaque, version_id)) 
> {
> +            continue;
> +        }
> +        if (field->version_id > version_id) {
> +            continue;
> +        }

What Markus observed...

I think the change is fine because we currently never have field_exists
and version_id set for the same field.

However, I suggest to move the change to a separate patch, and swap the
two ifs in this one.

Paolo

Reply via email to