On Wed, Oct 16, 2013 at 07:17:08PM +0200, Paolo Bonzini wrote: > This lock does not protect anything that the BQL does not already > protect. Furthermore, with -nodefaults and no monitor, the mutex > is not initialized but monitor_protocol_event_queue is called > anyway, which causes a crash under mingw (and only works by luck. > under Linux or other POSIX OSes). > > Reported-by: Orx Goshen <orx.gos...@intel.com> > Cc: Daniel Berrange <berra...@redhat.com> > Cc: qemu-sta...@nongnu.org > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > Maybe I'm missing something?
ACK, I only added it because I wasn't clear on wether the BQL was sufficient, so it was just a safety net. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
