于 2013/10/18 20:38, Eric Blake 写道:
On 10/18/2013 03:36 AM, Paolo Bonzini wrote:
Il 18/10/2013 03:11, Wenchao Xia ha scritto:
Signed-off-by: Wenchao Xia <xiaw...@linux.vnet.ibm.com>
---
  include/monitor/monitor.h |   38 +-------------------------
  include/qapi/qmp/qevent.h |   66 +++++++++++++++++++++++++++++++++++++++++++++
  include/qapi/qmp/types.h  |    1 +
  3 files changed, 68 insertions(+), 37 deletions(-)
  create mode 100644 include/qapi/qmp/qevent.h
Please move it qemu-schema.json instead.
qapi-schema.json, but yes, I agree that declaring it as a qapi enum and
letting the code generator create the constants, rather than moving the
hand-maintained constants into a new header, is smarter.

   I will try use qapi-schema.json in next version.


Reply via email to